Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Raise an error if ignore sender types is not supported #216

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

ServerAPI raises error if ignore sender types is not supported.

Additional review information

Right now passing ignore sender types silently does not ignore the fact that the filtering is not supported by server and raises an error.

Testing notes:

  1. Use server older than 1.5.5 and user enroll job with ignore sender types.
  2. It should crash.

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 25, 2024
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Nov 25, 2024
@iLLiCiTiT iLLiCiTiT merged commit 4bd059a into develop Nov 26, 2024
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/stricter-enroll-argument branch November 26, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant