Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical alignment distribution of data fix #25

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Vertical alignment distribution of data fix #25

merged 7 commits into from
Nov 12, 2024

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Nov 6, 2024 •
edited
Loading

Changelog Description

Adjusted vertical alignment and distribution of data in the code to ensure proper handling and organization of clip metadata.

Testing notes:

  1. Set your testing project timeline to have multiple tracks
  2. rename those track to be P01, P02, P02
  3. add some clip to P01
  4. add other shorter clips to other tracks above and make sure their duration is not longer than clip in P01 and its full framerange is between IN and OUT of P01
  5. select all clips and open Creator,
  6. Set vertical alignment to active
  7. Set hero track to P01
  8. Create and notice all clips were renamed to the same name and all instances are having the same clip name.

Closes #28

@jakubjezek001
Vertical alignment distribution of data fix
785925f 
- Adjusted vertical alignment and distribution of data in the code to ensure proper handling and organization of clip metadata.
@jakubjezek001 jakubjezek001 self-assigned this Nov 6, 2024
@jakubjezek001 jakubjezek001 added sponsored This is directly sponsored by a client or community member type: bug Something isn't working labels Nov 6, 2024
@robin-ynput
Copy link
Contributor

robin-ynput commented Nov 6, 2024 •
edited
Loading

Just to be sure, is this one related to #12 or is it something else ?

@jakubjezek001
Adjust clip duplication check logic and form unique key for used clips.
a2a30b5 
- Refactored condition to handle clip boundaries.
- Added formation of a unique key for each used clip.
@jakubjezek001
improving distribution of hero track data and variant
0ab6151
@jakubjezek001
Refactor product name generation logic in PublishClip class
aa5bea3 
Simplify product name creation by using the 'variant' attribute instead of 'base_product_variant'. Update comparison to use 'variant' for consistency.
@jakubjezek001
Copy link
Member Author

jakubjezek001 commented Nov 12, 2024 •
edited
Loading

Just to be sure, is this one related to #12 or is it something else ?

yes, only partly. I have added sub-issues and this is the related one #28

@jakubjezek001 jakubjezek001 merged commit 62fc7d9 into develop Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilaKudr MilaKudr MilaKudr approved these changes

@robin-ynput robin-ynput Awaiting requested review from robin-ynput

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@jakubjezek001 jakubjezek001

Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertical alignment workflow is broken
4 participants
@jakubjezek001 @robin-ynput @iLLiCiTiT @MilaKudr