Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail better when no DL webservice connection #69

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Nov 25, 2024

Changelog Description

Without this it throws weird Enum error.

Testing notes:

  1. run Publisher with not running DL webservice, it should show dropdowns with '< none >' values

@kalisp kalisp self-assigned this Nov 25, 2024
@iLLiCiTiT
Copy link
Member

I did small change as it would be hard to do suggestion.

There were few issues:

  1. All the variables pointed to same list object -> they would have 4 none items if it would fail.
  2. The value of none item was not None but "< none >".

@MilaKudr
Copy link

I am not able to create bundle.
Screenshot 2024-11-25 155637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants