Remove multi-context restrictions for publishing image sequences on farm #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
type: enhancement
BigRoy
reviewed
Feb 13, 2024
Comment on lines
-78
to
-94
| # set context by first json file | ||
| ctx = self._context.data | ||
|
|
||
| ctx["asset"] = ctx.get("asset") or data.get("asset") | ||
| ctx["intent"] = ctx.get("intent") or data.get("intent") | ||
| ctx["comment"] = ctx.get("comment") or data.get("comment") | ||
| ctx["user"] = ctx.get("user") or data.get("user") | ||
| ctx["version"] = ctx.get("version") or data.get("version") | ||
|
|
||
| # basic sanity check to see if we are working in same context | ||
| # if some other json file has different context, bail out. | ||
| ctx_err = "inconsistent contexts in json files - %s" | ||
| assert ctx.get("asset") == data.get("asset"), ctx_err % "asset" | ||
| assert ctx.get("intent") == data.get("intent"), ctx_err % "intent" | ||
| assert ctx.get("comment") == data.get("comment"), ctx_err % "comment" | ||
| assert ctx.get("user") == data.get("user"), ctx_err % "user" | ||
| assert ctx.get("version") == data.get("version"), ctx_err % "version" |
There was a problem hiding this comment.
Technically - when is this is valid. If I have two .json files that specify a different running context to publish in this may be very dangerous because now suddenly that context isn't actually used for ONE of the json files?
I think, yes we should not assert that instance context must MATCH the gloibal context - but if we were to load multiple JSON files at once we should still assert the global context of both JSON files is shared between them.
There was a problem hiding this comment.
@BigRoy this is just a port. Could you comment on the original PR; ynput/OpenPype#6088 ?
|
Implemented by #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Port of ynput/OpenPype#6088