Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix Houdini publish button bugs #32

Closed
wants to merge 14 commits into from

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Feb 12, 2024

Changelog Description

Ported from OP ynput/OpenPype#5891

Self publish had few bugs

  1. Unnecessary faulty logic in find_rop_input_dependencies function which caused karma and HDA publishes to fail.
  2. Recursive rop rendering as each extractor was rendering all input nodes!

Solution:

  1. refactor find_rop_input_dependencies to find_rop_inputs_chain with much simpler logic.
  2. adding ignore_inputs flag in render_rop function

Testing notes:

  1. use self publish buttons to publish karma and HDA
  2. use different combinations and it should still work

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Feb 12, 2024

For reference, This PR was made mainly to avoid the nested rendering + fix the problem when using the publish button with karma product type.

Also, BigRoy mentioned here ynput/OpenPype#5891 (comment) this PR doesn't "do much" as it doesn't correctly solve the raised problems.. thus I'm converting this to draft and leaving it open for discussion.

@MustafaJafar MustafaJafar marked this pull request as draft February 12, 2024 15:02
@moonyuet
Copy link
Member

moonyuet commented Feb 22, 2024

For reference, This PR was made mainly to avoid the nested rendering + fix the problem when using the publish button with karma product type.

Also, BigRoy mentioned here ynput/OpenPype#5891 (comment) this PR doesn't "do much" as it doesn't correctly solve the raised problems.. thus I'm converting this to draft and leaving it open for discussion.

I did the simple test run for this PR and it works smoothly.
@BigRoy @antirotor should we continue to build on the ordering with this PR or should we create issues based upon that to come up with the possible solutions on the chain problem mentioned in the same PR from OpenPype?

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Apr 2, 2024

Closing this PR in favor of searching for better solutions.
Also, the best part of this PR (ignore inputs when rendering) was added in a dedicated PR #344

Also for reference. karma and HDA product types are the only ones that doesn't work with self_publish_button in Houdini.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants