Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Extract active view as thumbnail when no thumbnail set #31

Merged
merged 20 commits into from
Apr 10, 2024

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Ported from OP ynput/OpenPype#6096

Add a function to take snapshoots from scene view in Houdini.
It works in different Houdini context e.g. Objects, Solaris.
For what it's worth, this function allows creating thumbnails image sequence by specifying fstart and fend.

Additional info

I think this functionality can be used to create thumbnails on the go when publishing.

Preview

image

Testing notes:

  1. Launch Houdini via Openpype or Ayon Launcher.
  2. publish workfile
  3. published workfiles should have a thumbnail, you will be able to see that in loader.

@BigRoy
Copy link
Collaborator

BigRoy commented Feb 12, 2024

Can we change PR title + description snapshoots to snapshots? I assume PR title+description will find their way into changelogs. Likely best keep those free of typos where we can.

Also, can we get labels, like Houdini, etc. applied?

@MustafaJafar MustafaJafar changed the title Feature/houdini allow taking snapshoots Feature/houdini allow taking snapshots Feb 12, 2024
@MustafaJafar
Copy link
Contributor Author

Can we change PR title + description snapshoots to snapshots? I assume PR title+description will find their way into changelogs. Likely best keep those free of typos where we can.

My bad 🤦‍♂️

Also, can we get labels, like Houdini, etc. applied?

Sure! I just need to check if I should add Host labels to this repo as it's planned to split the hosts into their repos.

@MustafaJafar MustafaJafar changed the title Feature/houdini allow taking snapshots Houdini: Extract active view as thumbnail when no thumbnail set Feb 12, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Screencapture shown in the loader as expected in workfile family.

@ynbot ynbot added the type: feature Adding something new and exciting to the product label Feb 22, 2024
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some superfluous file from another PR, some docstring issue :) and some questionable use of NamedTemporaryFile

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some superfluous file from another PR, some docstring issue :) and some questionable use of NamedTemporaryFile

@MustafaJafar MustafaJafar force-pushed the feature/houdini_allow_taking_snapshoots branch from bf35212 to 5d60fb3 Compare March 4, 2024 13:41
@MustafaJafar MustafaJafar requested a review from BigRoy April 2, 2024 09:38
@MustafaJafar MustafaJafar requested a review from BigRoy April 2, 2024 10:37
@antirotor antirotor merged commit 1ece2de into develop Apr 10, 2024
1 check failed
@antirotor antirotor deleted the feature/houdini_allow_taking_snapshoots branch April 10, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini type: feature Adding something new and exciting to the product
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants