Here's a second version of the offline patch #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update against the fork
…gic. Code can now be imported as a module without executing code
…he class definitions) using reflections.
…a coin to be in 'beta' mode. 'beta' coins don't show up on the list until they are tested.
…TO ORIGINAL VERSION
Steve132
commented
Jul 6, 2018
|
Want any help merging this? The functionality is critical for a bunch of things and critical to my security model, and it can help other implementers too. |
|
Hey, I'll pay you a bounty to go through the head with me on hangouts and merge this (or a similar feature) into mainline. The way you want. Seriously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a second version of the offline patch. This time it includes multiple commits from the refactor so you can see and verify each step. Then, it includes also a commit that is flagged that shows when the functionality was unchanged and it was just a simple refactor. Finally, it includes all the commits to add the functionality.