clang-format: format entire codebase

* clang-format: simplify to BasedOnStyle and overrides

* clang-format: format everything

* clang-format: sort includes

* clang-format: reduce ColumnLimit to 90

* clang-format: set BreakConstructorInitializers: BeforeComma

* clang-tidy: init, start with readability-braces-around-statements

* clang-tidy: add modernize-deprecated-headers

* clang-tidy: add modernize-use-using

.clang-format

@@ -1,62 +1,6 @@
 BasedOnStyle:  Chromium
----
-Language:        Cpp
-AccessModifierOffset: -1
-ConstructorInitializerIndentWidth: 4
-AlignEscapedNewlinesLeft: true
-AlignAfterOpenBracket: true
-AlignTrailingComments: true
-AllowAllParametersOfDeclarationOnNextLine: false
-AllowShortBlocksOnASingleLine: false
-AllowShortCaseLabelsOnASingleLine: false
-AllowShortIfStatementsOnASingleLine: false
-AllowShortLoopsOnASingleLine: false
-AllowShortFunctionsOnASingleLine: Inline
-AlwaysBreakAfterDefinitionReturnType: false
-AlwaysBreakTemplateDeclarations: true
-AlwaysBreakBeforeMultilineStrings: true
-BreakBeforeBinaryOperators: false
-BreakBeforeTernaryOperators: true
-BreakConstructorInitializersBeforeComma: false
 BinPackArguments: false
 BinPackParameters: false
-ColumnLimit:     120
-ConstructorInitializerAllOnOneLineOrOnePerLine: true
-ConstructorInitializerIndentWidth: 4
-DerivePointerAlignment: false
-ExperimentalAutoDetectBinPacking: false
-IndentCaseLabels: true
-IndentWrappedFunctionNames: false
-IndentFunctionDeclarationAfterType: false
-MaxEmptyLinesToKeep: 1
-KeepEmptyLinesAtTheStartOfBlocks: false
-NamespaceIndentation: None
-PenaltyBreakBeforeFirstCallParameter: 1
-PenaltyBreakComment: 300
-PenaltyBreakString: 1000
-PenaltyBreakFirstLessLess: 120
-PenaltyExcessCharacter: 1000000
-PenaltyReturnTypeOnItsOwnLine: 200
-PointerAlignment: Left
-SpacesBeforeTrailingComments: 2
-Cpp11BracedListStyle: true
-Standard:        Cpp11
+ColumnLimit:     90
 IndentWidth:     2
-TabWidth:        8
-UseTab:          Never
-BreakBeforeBraces: Attach
-SpacesInParentheses: false
-SpacesInSquareBrackets: false
-SpacesInAngles:  false
-SpaceInEmptyParentheses: false
-SpacesInCStyleCastParentheses: false
-SpaceAfterCStyleCast: false
-SpacesInContainerLiterals: true
-SpaceBeforeAssignmentOperators: true
-ContinuationIndentWidth: 4
-CommentPragmas:  '^ IWYU pragma:'
-ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH ]
-SpaceBeforeParens: ControlStatements
-DisableFormat:   false
-...
-
+BreakConstructorInitializers: BeforeComma

.clang-tidy

@@ -0,0 +1 @@
+Checks: -*,readability-braces-around-statements,modernize-deprecated-headers,modernize-use-using

Archive/Archive.h

@@ -17,8 +17,8 @@
 #ifndef ARCHIVE_ARCHIVE_H_
 #define ARCHIVE_ARCHIVE_H_
 
-#include <string>
 #include <regex>
+#include <string>
 
 #include <archive.h>
 #include <archive_entry.h>
@@ -28,13 +28,15 @@
 // etc are derived.
 class Archive {
  public:
-  Archive(const std::string url, const bool plain_text) : url(url), plain_text(plain_text) {
+  Archive(const std::string url, const bool plain_text)
+      : url(url), plain_text(plain_text) {
     parse_url(url, url_parts);
 
     if (0 == (ar = archive_read_new()))
       throw std::runtime_error(std::string("archive_read_new failed!"));
 
-//!! LIBARCHIVE_ENABLE_ALL may trigger exception "detect_column_types error: libarchive error: Missing type keyword in
+//!! LIBARCHIVE_ENABLE_ALL may trigger exception "detect_column_types error: libarchive
+//! error: Missing type keyword in
 //! mtree specification"
 //!! on ridiculously simple raw data
 //#define LIBARCHIVE_ENABLE_ALL
@@ -84,7 +86,8 @@ class Archive {
 
   virtual std::string archive_error(int err) {
     auto cstr = archive_error_string(ar);
-    return std::string("libarchive error: ") + (cstr ? std::string(cstr) : std::to_string(err));
+    return std::string("libarchive error: ") +
+           (cstr ? std::string(cstr) : std::to_string(err));
   }
 
   virtual bool read_next_header() {
@@ -135,9 +138,13 @@ class Archive {
     return ((Archive*)client_data)->read(buff);
   }
 
-  static int open(struct archive* a, void* client_data) { return ((Archive*)client_data)->open(); }
+  static int open(struct archive* a, void* client_data) {
+    return ((Archive*)client_data)->open();
+  }
 
-  static int close(struct archive* a, void* client_data) { return ((Archive*)client_data)->close(); }
+  static int close(struct archive* a, void* client_data) {
+    return ((Archive*)client_data)->close();
+  }
 
   static void parse_url(const std::string url, std::map<int, std::string>& url_parts) {
     /*
@@ -155,7 +162,8 @@ class Archive {
                     9: cool
      */
     std::smatch sm;
-    std::regex url_regex(R"(^(([^:\/?#]+):)?(//([^\/?#]*))?([^?#]*)(\?([^#]*))?(#(.*))?)", std::regex::extended);
+    std::regex url_regex(R"(^(([^:\/?#]+):)?(//([^\/?#]*))?([^?#]*)(\?([^#]*))?(#(.*))?)",
+                         std::regex::extended);
     if (!std::regex_match(url, sm, url_regex))
       throw std::runtime_error(std::string("malformed url: ") + url);
 

Archive/PosixFileArchive.h

@@ -27,12 +27,14 @@ class PosixFileArchive : public Archive {
   const size_t buf_size = (1 << 20);
 
  public:
-  PosixFileArchive(const std::string url, const bool plain_text) : Archive(url, plain_text) {
+  PosixFileArchive(const std::string url, const bool plain_text)
+      : Archive(url, plain_text) {
     // some well-known file.exts imply plain text
     if (!this->plain_text)
-      this->plain_text =
-          boost::filesystem::extension(url_part(5)) == ".csv" || boost::filesystem::extension(url_part(5)) == ".tsv" ||
-          boost::filesystem::extension(url_part(5)) == ".txt" || boost::filesystem::extension(url_part(5)) == "";
+      this->plain_text = boost::filesystem::extension(url_part(5)) == ".csv" ||
+                         boost::filesystem::extension(url_part(5)) == ".tsv" ||
+                         boost::filesystem::extension(url_part(5)) == ".txt" ||
+                         boost::filesystem::extension(url_part(5)) == "";
 
     if (this->plain_text)
       buf = new char[buf_size];
@@ -51,10 +53,12 @@ class PosixFileArchive : public Archive {
     auto file_path = url_part(5);
     if (plain_text) {
       if (nullptr == (fp = fopen(file_path.c_str(), "r")))
-        throw std::runtime_error(std::string("fopen(") + file_path + "): " + strerror(errno));
+        throw std::runtime_error(std::string("fopen(") + file_path +
+                                 "): " + strerror(errno));
     } else {
       if (ARCHIVE_OK != archive_read_open_filename(ar, file_path.c_str(), 1 << 16))
-        throw std::runtime_error(std::string("fopen(") + file_path + "): " + strerror(errno));
+        throw std::runtime_error(std::string("fopen(") + file_path +
+                                 "): " + strerror(errno));
     }
   }