Check and simplify hash-join logic

yma11 · Jul 19, 2021 · 88f2451 · 88f2451
1 parent f4f962e
commit 88f2451
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/QueryEngine/JoinHashTable/HashJoin.cpp b/QueryEngine/JoinHashTable/HashJoin.cpp
@@ -623,8 +623,7 @@ InnerOuter normalize_column_pair(const Analyzer::Expr* lhs,
   auto outer_ti = lhs_ti;
   auto inner_ti = rhs_ti;
   const Analyzer::Expr* outer_expr{lhs};
-  if ((!lhs_col || (rhs_col && lhs_col->get_rte_idx() < rhs_col->get_rte_idx())) &&
-      (!rhs_col || (!lhs_col || lhs_col->get_rte_idx() < rhs_col->get_rte_idx()))) {
+  if (!lhs_col || (rhs_col && lhs_col->get_rte_idx() < rhs_col->get_rte_idx())) {
     inner_col = rhs_col;
     outer_col = lhs_col;
   } else {