Skip to content

Commit

Permalink
S3 Select client and tests
Browse files Browse the repository at this point in the history
This class will be used by the S3 select based CSV wrapper, allowing access to individual columns, as well as metadata generation for some types.
The tests are currently not run as part of sanity_tests as a valid AWS_ACCESS_KEY_ID needs to be set in the environment to run the test.
  • Loading branch information
alex-brant authored and andrewseidl committed Jan 25, 2021
1 parent e4d26ea commit 15827c0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions DataMgr/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ set(datamgr_source_files
if("${MAPD_EDITION_LOWER}" STREQUAL "ee")
if(ENABLE_AWS_S3)
list(APPEND datamgr_source_files ForeignStorage/ee/CsvReaderS3.cpp)
list(APPEND datamgr_source_files ForeignStorage/ee/S3Utils.cpp)
list(APPEND datamgr_source_files ForeignStorage/ee/S3SelectClient.cpp)
endif()
endif()

Expand Down
2 changes: 2 additions & 0 deletions Tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ endif()
if(("${MAPD_EDITION_LOWER}" STREQUAL "ee") AND ENABLE_AWS_S3)
target_link_libraries(UserMappingDdlTest ${THRIFT_HANDLER_TEST_LIBRARIES})
target_link_libraries(PkiEncryptorTest gtest Logger Shared)
target_link_libraries(S3SelectClientTest ${EXECUTE_TEST_LIBS})
endif()

set(TEST_ARGS "--gtest_output=xml:../")
Expand Down Expand Up @@ -276,6 +277,7 @@ endif()
if(("${MAPD_EDITION_LOWER}" STREQUAL "ee") AND ENABLE_AWS_S3)
add_test(UserMappingDdlTest UserMappingDdlTest ${TEST_ARGS})
add_test(PkiEncryptorTest PkiEncryptorTest ${TEST_ARGS})
add_test(S3SelectClientTest S3SelectClientTest ${TEST_ARGS})
endif()

add_executable(ArrowIpcIntegrationTest ArrowIpcIntegrationTest.cpp)
Expand Down

0 comments on commit 15827c0

Please sign in to comment.