Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #23

Merged
merged 4 commits into from
May 6, 2020
Merged

Tests #23

merged 4 commits into from
May 6, 2020

Conversation

rustamwin
Copy link
Member

@rustamwin rustamwin commented May 1, 2020 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues #22

@rustamwin rustamwin added the type:test Test label May 1, 2020
@rustamwin rustamwin requested a review from a team May 1, 2020 18:17
@rustamwin
Copy link
Member Author

Gii

@samdark samdark added the status:code review The pull request needs review. label May 2, 2020
samdark
samdark approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are OK but how configuration is implemented is questionable. Let's merge tests first.

src/Factory/GiiFactory.php Show resolved Hide resolved
@samdark samdark merged commit 720eb3c into yiisoft:master May 6, 2020
@rustamwin rustamwin deleted the tests branch May 6, 2020 20:44
devanych pushed a commit that referenced this pull request Dec 19, 2020
@rustamwin @devanych
Fix tests (#23)
2126ffa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review. type:test Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustamwin @samdark