Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to last changes in Yii Data and Yii Router FastRoute #149

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 8, 2024

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Copy link

what-the-diff bot commented Jan 8, 2024

PR Summary

  • Update in composer.json
    The version of yiisoft/router-fastroute was updated to ensure compatibility and performance improvements.

  • Changes in src/BaseListView.php
    Additional functionalities have been incorporated into methods renderPagination() and renderSummary() for better efficiency.

  • Modification in src/BasePagination.php
    Method createUrl() was updated to improve the generation of URLs in the application.

  • Updates in src/Column/Base/GlobalContext.php
    Annotations were added to make the codebase better documented and easier to understand.

  • Revisions in src/LinkSorter.php
    The createUrl() method was updated for better URL generation.

  • Changes in src/YiiRouter/ActionColumnUrlCreator.php
    Minor changes in property values to improve the query parameters formation.

  • Updates to Test Files
    Various testing methods across multiple files were modified to align with the recent changes and enhancements.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4f314c) 90.49% compared to head (1e8c358) 90.40%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
- Coverage     90.49%   90.40%   -0.10%     
+ Complexity      475      471       -4     
============================================
  Files            33       33              
  Lines          1673     1667       -6     
============================================
- Hits           1514     1507       -7     
- Misses          159      160       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Jan 8, 2024
@vjik vjik requested a review from a team January 8, 2024 17:13
@vjik vjik merged commit 35df674 into master Jan 9, 2024
16 of 19 checks passed
@vjik vjik deleted the adapt branch January 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants