Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AbstractColumnDefinitionBuilder #901

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Refactor AbstractColumnDefinitionBuilder #901

merged 2 commits into from
Nov 17, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 17, 2024 •
edited
Loading

This was referenced Nov 17, 2024
Merged
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (49647d9) to head (9d71e37).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #901      +/-   ##
============================================
- Coverage     99.60%   99.60%   -0.01%     
+ Complexity     1540     1539       -1     
============================================
  Files            81       81              
  Lines          3801     3800       -1     
============================================
- Hits           3786     3785       -1     
  Misses           15       15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Nov 17, 2024
Merged
Merged
@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 17, 2024
@Tigrov Tigrov requested a review from a team November 17, 2024 06:18
@Tigrov Tigrov merged commit 3167625 into master Nov 17, 2024
3 checks passed
@Tigrov Tigrov deleted the refactor-column-definition-builder branch November 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tigrov @samdark