Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realize ColumnBuilder #878

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Realize ColumnBuilder #878

merged 7 commits into from
Sep 16, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 8, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.81657% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.57%. Comparing base (e3e277d) to head (88563b2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Schema/Column/AbstractColumnFactory.php 96.49% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #878      +/-   ##
============================================
- Coverage     99.61%   99.57%   -0.04%     
- Complexity     1389     1425      +36     
============================================
  Files            75       77       +2     
  Lines          3405     3557     +152     
============================================
+ Hits           3392     3542     +150     
- Misses           13       15       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Sep 8, 2024
Merged
Merged
Merged
Merged
Merged
Tigrov and others added 3 commits September 13, 2024 08:26
@Tigrov
Merge branch 'refs/heads/master' into add-column-builder
66a3ab1 
# Conflicts:
#	src/Constant/PseudoType.php
#	src/Schema/Column/AbstractColumnFactory.php
#	src/Schema/Column/ColumnFactoryInterface.php
#	tests/Provider/ColumnFactoryProvider.php
@Tigrov
Remove ColumnFactory from ColumnBuilder
926c925
@StyleCIBot
Apply fixes from StyleCI
096212b
@Tigrov Tigrov merged commit c765ca4 into master Sep 16, 2024
56 of 58 checks passed
@Tigrov Tigrov deleted the add-column-builder branch September 16, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tigrov @vjik @StyleCIBot