Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor data readers #822

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor data readers #822

wants to merge 3 commits into from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Apr 17, 2024

  • Refactor DataReader class
  • Rename DataReader to PdoDataReader class
  • Refactor BatchQueryResult
  • Use DataReaderInterface as a result of method Query::each()

As a result ->rewind() can be called multiple times before iteration. It allows to get access to the first row before iteration.

Related PR

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC? ✔️
Fixed issues #821, #716

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 99.41%. Comparing base (e380ae2) to head (884e9c7).

Files Patch % Lines
src/Query/BatchQueryResult.php 85.71% 3 Missing ⚠️
src/Driver/Pdo/PdoDataReader.php 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #822      +/-   ##
============================================
- Coverage     99.56%   99.41%   -0.16%     
+ Complexity     1316     1311       -5     
============================================
  Files            64       64              
  Lines          3236     3228       -8     
============================================
- Hits           3222     3209      -13     
- Misses           14       19       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:under development Someone is working on a pull request. label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants