Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method alterColumn(), argument type accept ColumnInterface::class. #741

Merged
merged 8 commits into from
Aug 15, 2023

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Aug 14, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues yiisoft/db-migration#187

@what-the-diff
Copy link

what-the-diff bot commented Aug 14, 2023

PR Summary

  • Updated Environment Variable

    • The COMPOSER_ROOT_VERSION was upgraded to 1.1.0. This updates the development environment to use the latest toolkit for the PHP library, which could lead to more efficient code execution.
  • Adjusted Supported PHP Versions

    • The supported PHP versions were updated to include more recent PHP versions (8.1, 8.2), removing the older version (8.0). This will allow the application to leverage advancements and security fixes in more recent PHP versions.
  • Changelog Updates

    • The update notes reflect several important changes including modifications to the alterColumn() method to accept a new type of argument, adding a debug collector for better debugging capabilities, and introducing specific annotations for better code clarity and maintainability in the ConnectionInterface::transaction() method.
  • Updated Dependency

    • The compatible version for vimeo/psalm was updated to include the latest version. This enables better static analysis of code, reducing the potential for bugs or vulnerabilities.
  • Exclusion of Directories/Files from Tests

    • Numerous directories and files were excluded from PHPUnit tests. This could result in faster testing as now certain tests that were not needed will not be performed, saving time during development cycles.
  • Improved Type Supporting in alterColumn() Method

    • Updates to the alterColumn() method across several files were made to accept a new type of argument. This provides more flexibility in handling column modifications in databases, allowing for better performance and readability in database operation code.

@terabytesoftw terabytesoftw changed the title Fix method alterCOlumn(), argument type accept ColumnInterface::class. Fix method alterColumn(), argument type accept ColumnInterface::class. Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +10.14% 🎉

Comparison is base (c5aa0b1) 89.59% compared to head (a13cb2e) 99.73%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #741       +/-   ##
=============================================
+ Coverage     89.59%   99.73%   +10.14%     
+ Complexity     1375     1269      -106     
=============================================
  Files            67       63        -4     
  Lines          3382     3038      -344     
=============================================
  Hits           3030     3030               
+ Misses          352        8      -344     
Files Changed Coverage Δ
src/Command/AbstractCommand.php 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw merged commit b047dae into master Aug 15, 2023
162 of 163 checks passed
@terabytesoftw terabytesoftw deleted the fix-method-alter-colum branch August 15, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants