Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve column type #230

Merged
merged 13 commits into from
Sep 2, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 4, 2023

  • Better detect Oracle column type
  • Improve type time
Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Aug 4, 2023

PR Summary

  • Upgrade of Data Types in Query Builder
    In the section where we write queries for the database, critical changes have been made to refine how we deal with different data types. This change primarily concerns data types such as FLOAT, DOUBLE, DECIMAL, timestamps, and time-related types, making them compatible with Oracle's way of handling these types.

  • Enhanced Column Type Detection in Schema
    In the Schema part of our code, which handles the organizational structure of our data, we've added a new feature. A mapping now exists that ties physical column types (what the database directly sees) to abstract column types (a more general, simplified category). This new setup means our software can now more effectively determine the type of data held in a column, therefore improving our ability to manipulate that data correctly.

  • Testing Enhancements
    We've introduced improvements in our testing environment to check the new changes effectively. Specifically, we've added a new column to keep track of time, and adjusted some of our test methods to handle time data differently. This ensures that we don't just make changes, but we also have a robust way to verify they work.

  • Database Modifications
    Our mock database used for testing purposes has been adjusted to reflect these changes, ensuring that our automatic checks align with the improvements made.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6bb534e) 98.29% compared to head (ce8db20) 98.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #230   +/-   ##
=========================================
  Coverage     98.29%   98.29%           
- Complexity      186      187    +1     
=========================================
  Files            16       16           
  Lines           585      585           
=========================================
  Hits            575      575           
  Misses           10       10           
Files Changed Coverage Δ
src/QueryBuilder.php 100.00% <ø> (ø)
src/Schema.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 4, 2023 16:41
src/Schema.php Show resolved Hide resolved
src/QueryBuilder.php Show resolved Hide resolved
src/QueryBuilder.php Show resolved Hide resolved
src/Schema.php Outdated Show resolved Hide resolved
@samdark samdark requested a review from terabytesoftw August 11, 2023 14:05
@terabytesoftw terabytesoftw merged commit 6888e26 into yiisoft:master Sep 2, 2023
@Tigrov Tigrov deleted the improve_oracle_column_type branch September 3, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants