Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core library and tag new version 0.1-016 #53

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Update core library and tag new version 0.1-016 #53

merged 2 commits into from
Nov 29, 2023

Conversation

basilgello
Copy link
Contributor

@basilgello basilgello commented Nov 29, 2023 •
edited
Loading

  • Bump yggdrasil-go submodule to 0.5.4
  • Fix VPN connection not closed on Yggdrasil switch toggled off
  • Version 0.1-016

neilalexander
neilalexander approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle LGTM, but I don't think updating the submodule does anything as I think CI always checks out develop.

@basilgello
Copy link
Contributor Author

CI yes but F-Droid might think different :)

@basilgello
Copy link
Contributor Author

Also fixed VPN connection not destroyed on switch off.

@basilgello basilgello changed the title Update core library and tag new version Update core library and tag new version 0.1-016 Nov 29, 2023
@Revertron
Copy link
Collaborator

We need to merge #54 before this.

Revertron
Revertron approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@Revertron Revertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, let's merge.

@Revertron Revertron merged commit d1ebc97 into yggdrasil-network:main Nov 29, 2023
1 check passed
@basilgello
Copy link
Contributor Author

Great! And new tag :)

@Revertron
Copy link
Collaborator

Great! And new tag :)

Done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

@Revertron Revertron Revertron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basilgello @Revertron @neilalexander