Skip to content

Commit

Permalink
Provide reference ref for benchmark action and make it less spammy (#…
Browse files Browse the repository at this point in the history
…3716)

* provide reference ref for benchmark action

it's apparently not possible to also provide a PR number for the comment
to target, since that is automically determined by the action (and wrong
for workflow_run workflows)

See also: benchmark-action/github-action-benchmark#250

* guard benchmark action with performance label again

This check was removed in #2774 for simplicity, bring it back to spam less
  • Loading branch information
WorldSEnder authored Aug 23, 2024
1 parent aa21119 commit aecde4b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ concurrency:

jobs:
benchmark:
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'performance')
runs-on: ubuntu-latest

steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/post-benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ jobs:
# Enable job summary
summary-always: true
comment-always: true
ref: ${{ github.event.workflow_run.head_sha }}

1 comment on commit aecde4b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yew master branch benchmarks (Lower is better)

Benchmark suite Current: aecde4b Previous: aa21119 Ratio
yew-hooks-v0.21.0-keyed 01_run1k 190.4 194.6 0.98
yew-hooks-v0.21.0-keyed 02_replace1k 215.1 215 1.00
yew-hooks-v0.21.0-keyed 03_update10th1k_x16 89.9 90.9 0.99
yew-hooks-v0.21.0-keyed 04_select1k 37.5 38.7 0.97
yew-hooks-v0.21.0-keyed 05_swap1k 97.8 105 0.93
yew-hooks-v0.21.0-keyed 06_remove-one-1k 74.1 80.9 0.92
yew-hooks-v0.21.0-keyed 07_create10k 2172.3 2223.1 0.98
yew-hooks-v0.21.0-keyed 08_create1k-after1k_x2 221.9 234.1 0.95
yew-hooks-v0.21.0-keyed 09_clear1k_x8 82.3 87.5 0.94
yew-hooks-v0.21.0-keyed 21_ready-memory 2.148773193359375 2.08194351196289 1.03
yew-hooks-v0.21.0-keyed 22_run-memory 6.287147521972656 6.311489105224609 1.00
yew-hooks-v0.21.0-keyed 23_update5-memory 6.545445442199707 6.596413612365723 0.99
yew-hooks-v0.21.0-keyed 25_run-clear-memory 5.162281036376953 5.168736457824707 1.00
yew-hooks-v0.21.0-keyed 26_run-10k-memory 42.82865524291992 42.82847213745117 1.00
yew-hooks-v0.21.0-keyed 41_size-uncompressed 168.4 168.4 1
yew-hooks-v0.21.0-keyed 42_size-compressed 54.6 54.6 1
yew-hooks-v0.21.0-keyed 43_first-paint 419.9 464.6 0.90
yew-v0.21.0-keyed 01_run1k 192.8 199.1 0.97
yew-v0.21.0-keyed 02_replace1k 215.9 221.2 0.98
yew-v0.21.0-keyed 03_update10th1k_x16 65.3 71.7 0.91
yew-v0.21.0-keyed 04_select1k 15.8 17.1 0.92
yew-v0.21.0-keyed 05_swap1k 74.6 89.7 0.83
yew-v0.21.0-keyed 06_remove-one-1k 63.5 65.2 0.97
yew-v0.21.0-keyed 07_create10k 2192.1 2181.8 1.00
yew-v0.21.0-keyed 08_create1k-after1k_x2 216.2 221.8 0.97
yew-v0.21.0-keyed 09_clear1k_x8 81.2 83.2 0.98
yew-v0.21.0-keyed 21_ready-memory 2.120767593383789 2.1210689544677734 1.00
yew-v0.21.0-keyed 22_run-memory 6.180402755737305 6.219568252563477 0.99
yew-v0.21.0-keyed 23_update5-memory 6.320826530456543 6.362386703491211 0.99
yew-v0.21.0-keyed 25_run-clear-memory 5.010980606079102 4.960691452026367 1.01
yew-v0.21.0-keyed 26_run-10k-memory 41.578298568725586 41.536179542541504 1.00
yew-v0.21.0-keyed 41_size-uncompressed 166.1 166.1 1
yew-v0.21.0-keyed 42_size-compressed 54.3 54.3 1
yew-v0.21.0-keyed 43_first-paint 427.1 443.7 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.