-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add base #577
Closed
Closed
feat: add base #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xBasically
force-pushed
the
feat-add-base
branch
from
August 31, 2023 13:32
4741583
to
768650d
Compare
0xBasically
force-pushed
the
feat-add-base
branch
6 times, most recently
from
September 6, 2023 19:14
a5e4fe5
to
29645e4
Compare
0xBasically
force-pushed
the
feat-add-base
branch
from
September 7, 2023 13:56
571d4d7
to
9e911d5
Compare
* fix: price err tvl edge case * chore: cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue # (if applicable):
What I did:
add base network to exporter
How I did it:
How to verify it:
source .env
make up network=base
Checklist:
Network: Base
Chain ID: 8453
in ./yearn/constants.py:
in ./yearn/prices/constants.py:
tokens_by_network
.tokens_by_network
.tokens_by_network
.stablecoins
using popular + "safe" stablecoins on the chain.wrapped_gas_coin
field.in ./yearn/multicall2.py:
in ./yearn/ironbank.py:
in ./yearn/prices/compound.py:
in ./yearn/v2/registry.py:
in yearn/yearn.py:
in ./yearn/prices/constants.py:
ib_snapshot_block_by_network
, if any, the start block of Ironbank on this network or specify '1' if not applicable.in ./yearn/prices/uniswap/v2.py:
in ./yearn/prices/uniswap/v3.py:
add info about uni v3 deployed on network
in ./yearn/utils.py:
BINARY_SEARCH_BARRIER
as 0 if all historical data is available. If historical data not available due to a network upgrade/etc, specify the first block of the available historical data.in ./yearn/middleware/middleware.py:
BATCH_SIZE
of approx 1 day based on avg block times on the chain.in ./scripts/historical-exporter.py:
end
to equal the date + hour of deployment for the first Yearn product on the chain.data_query
. Seemapping
in ./yearn/outputs/victoria/output_helper.py to figure out the metric to specify based on what type of product was the first deployed on the chain.in ./scripts/historical-treasury-exporter.py:
end
to equal the date + hour of deployment for the Yearn Treasury on the chain.data_query
using the existing networks as an example.in ./scripts/historical-sms-exporter.py:
end
to equal the date + hour of deployment for the Strategist Multisig on the chain.data_query
using the existing networks as an example.You also need to set up containers for each exporter on the new chain. This is a little more complicated but you can use existing containers as an example:
in ./Makefile: Set up network specific make command.
It's important to test to make sure everything works!
Once you've handled everything above, type
make up <network>
into your terminal replacing network with your network name at the project root. The network specific exporters will start running in docker and any exceptions will show in your terminal. If there are no exceptions, and everything appears to be running smoothly then it should be working correctly.