fix(lending): ensure supplyAsset button text appears #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xSake
commented
Feb 23, 2021
0xSake
commented
- closes (Lending page buttons not displaying #245)
- a bug was reported that asset.balance is a string so none of these conditionals pass (yearn#245) - cast asset.balance to a Number so the equality checks works
0xSake
force-pushed
the
fix/lending-page-buttons
branch
from
5b5bcb1
to
a0e7232
Compare
ghost
approved these changes
Feb 23, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.