use release omnisharp #188
Conversation
corngood
force-pushed
the
release_omnisharp
branch
from
ef6df3e to
94c1d93
Compare
|
This change now contains the submodule update to include the fix in omnisharp-server. |
|
What I didn't understand is what this should bring to the user and at this point why we were using the debug version of Omnisharp. |
|
📌 Commit 94c1d93 has been approved by |
WIP: use release omnisharp Using the release configuration of OmniSharp. *** There are currently bugs with the Release configuration that need to be fixed with OmniSharp/omnisharp-server#206, so this shouldn't be merged until the OmniSharp fix is merged and the submodule updated. I'll update this PR if/when that happens.
|
I'm not sure why it was originally using Debug, but it could be because of the solution configuration problem I referenced above. Release in the omnisharp .sln was building the silverlight configuration of some dependencies, which stopped it from locating mscorlib etc. As far as performance goes, I unfortunately don't have hard numbers at the moment, but I did this originally because I was trying to profile a severe performance problem in one of the code issue modules (icsharpcode/NRefactory#476). This sort of thing is CPU limited managed code, so there is a decent improvement. |
|
☀️ Test successful - status |
Using the release configuration of OmniSharp.
*** There are currently bugs with the Release configuration that need to be fixed with OmniSharp/omnisharp-server#206, so this shouldn't be merged until the OmniSharp fix is merged and the submodule updated. I'll update this PR if/when that happens.