add Coveralls support with new /coveralls endpoint #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coveralls (http://coveralls.io/) can send a webhook when it has new coverage data for a change: https://coveralls.zendesk.com/hc/en-us/articles/201774895-Notifications this adds support for that with a new /coveralls endpoint. it's mostly the same as the /hook/... endpoint, and reuses most of the code, but looks up the GitHub PR based on the commit hash. it also mildly refactors GithubBot.process_hook a bit to allow unset build_id, since Coveralls doesn't send one in its webhook.
| @app.route('/hook/<pull_request_id>/<path:object_key>') | ||
| def hook_view(pull_request_id, object_key): | ||
| repo_name = request.args.get('repo_name') | ||
| def hook(args): |
There was a problem hiding this comment.
Since this is a general hook function now, it might make sense to move it into a file in helpers, keeping this file only for route definitions.
* move hook helper to helpers/update.py * expect lang query param in coveralls endpoint * style and error handling fixes
|
thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coveralls (http://coveralls.io/) can send a webhook when it has new coverage data for a change: https://coveralls.zendesk.com/hc/en-us/articles/201774895-Notifications
this adds support for that with a new /coveralls endpoint. it's mostly the same as the /hook/... endpoint, and reuses most of the code, but looks up the GitHub PR based on the commit hash.
it also mildly refactors GithubBot.process_hook a bit to allow unset build_id, since Coveralls doesn't send one in its webhook.