FND-1551: UPDATE all optional attributes should be allowed to be omitted #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juriku
reviewed
Nov 28, 2024
| @@ -26,8 +26,12 @@ spec: | |||
| {{- if .Values.keda.scaleTargetRef.envSourceContainerName }} | |||
| envSourceContainerName: {{ .Values.keda.scaleTargetRef.envSourceContainerName }} | |||
| {{- end }} | |||
| pollingInterval: {{ .Values.keda.pollingInterval | default 30 }} | |||
| cooldownPeriod: {{ .Values.keda.cooldownPeriod | default 300 }} | |||
| {{- if .Values.keda.pollingInterval }} | |||
There was a problem hiding this comment.
the problem with those that keda will set default values regardless, therefore it might be misleading to make it optional
There was a problem hiding this comment.
Yes, I want the keda defaults & not predefined defaults. It adds more complexity as it has a default value here & a default value in values.yaml & neither are needed.
There was a problem hiding this comment.
easier to manage them with helm, because if you remove them, then they still will be there
There was a problem hiding this comment.
But I don't want them there. The purpose of the PR is to only set them when they're defined.
juriku
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.