Checkbox get label improvement #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't think we need such complex heuristics in framework. you can write your own "labeled checkbox" element, where describe how to find a label. |
|
These are not a complex heuristics @artkoshelev , but merely a way of finding element's label, used by browser. I've did similar things in PHP version of HtmlElements: https://github.com/qa-tools/qa-tools/blob/master/library/QATools/QATools/HtmlElements/Element/LabeledElement.php#L29-L48 In fact I've standardized label locating way for every element that can have label (e.g. radio button and checkbox), so no code duplication occurs, as in this case. |
| if (id != null) { | ||
| // Label with matching "for" attribute | ||
| // Trying to find element from !ROOT! node | ||
| String xpath = String.format("(//label[@for = %s])[1]", id); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 issue