fix: prevent NullPointerException when webdriver.timeouts.implicitlyw…

…ait=0
yandex-qatools · Mar 12, 2018 · 64d5857 · 64d5857
1 parent f4e5cf5
commit 64d5857
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/...ndex/qatools/htmlelements/loader/decorator/proxyhandlers/WebElementNamedProxyHandler.java b/...ndex/qatools/htmlelements/loader/decorator/proxyhandlers/WebElementNamedProxyHandler.java
@@ -36,18 +36,18 @@ public Object invoke(Object o, Method method, Object[] objects) throws Throwable
             return name;
         }
 
-        long end = this.clock.laterBy(TimeUnit.SECONDS.toMillis(this.timeOutInSeconds));
+        final long end = this.clock.laterBy(TimeUnit.SECONDS.toMillis(this.timeOutInSeconds));
 
-        StaleElementReferenceException lasException = null;
-        while (this.clock.isNowBefore(end)) {
+        StaleElementReferenceException lastException;
+        do {
             try {
                 return super.invoke(o, method, objects);
             } catch (StaleElementReferenceException e) {
-                lasException = e;
+                lastException = e;
                 this.waitFor();
             }
-        }
-        throw lasException;
+        } while (this.clock.isNowBefore(end));
+        throw lastException;
     }
 
     protected long sleepFor() {

diff --git a/...ents-java/src/test/java/ru/yandex/qatools/htmlelements/HtmlElementLocatorTimeoutTest.java b/...ents-java/src/test/java/ru/yandex/qatools/htmlelements/HtmlElementLocatorTimeoutTest.java
@@ -44,7 +44,17 @@ public void classFieldsTimeout() throws NoSuchFieldException {
 
     @Test
     public void timeoutWithSystemProperty() {
-        System.setProperty("webdriver.timeouts.implicitlywait", "1");
-        Assert.assertEquals(1, factory.getTimeOut(HtmlElement.class));
+        final String propertyName = "webdriver.timeouts.implicitlywait";
+        final String previousTimeout = System.getProperty(propertyName);
+        System.setProperty(propertyName, "1");
+        try {
+            Assert.assertEquals(1, factory.getTimeOut(HtmlElement.class));
+        } finally {
+            if (previousTimeout == null) {
+                System.getProperties().remove(propertyName);
+            } else {
+                System.setProperty(propertyName, previousTimeout);
+            }
+        }
     }
 }