Fix include path issue for libyaml #618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under FreeBSD, clang-based cc doesn't have `/usr/local/include` within its default include paths, so this patch will add it using `pkg-config` when necessary so the C extension is able to build when installing. This should fix the abruptly closed and locked yaml#616, without breaking builds on other systems.
Tested and works both on Linux and FreeBSD.
|
This should be working now, as intended. I've tested it both on my FreeBSD server and on my Linux box, both build the extension successfully. |
|
Hey, I've just resolved the merge conflict. Here's to hoping it's gonna end up in the production release soon. Cheers, |
|
Hey @nitzmahone, any chance of merging this? I have customizations necessary in a couple of my project until this gets merged. So merging it would be highly appreciated. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under FreeBSD, clang-based cc doesn't have
/usr/local/includewithin its default include paths, so this patch will add it usingpkg-configwhen necessary so the C extension is able to build when installing.This should fix the abruptly closed and locked #616, without breaking builds on other systems.