Merge pull request #77 from yalla-coop/remove-edit-salessession

Remove the ability to edit a sales session as we dont support it on the producer
yalla-coop · Jul 30, 2024 · a591c35 · a591c35
2 parents c7b5aaf + 0cee723
commit a591c35
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 134 deletions.
diff --git a/web/frontend/pages/SalesSession.jsx b/web/frontend/pages/SalesSession.jsx
@@ -90,22 +90,6 @@ export default function SalesSession() {
     },
   });
 
-  const {
-    mutateAsync: editCurrentSalesSession,
-    isLoading: editCurrentSalesSessionIsLoading,
-    error: editCurrentSalesSessionError,
-  } = useAppMutation({
-    reactQueryOptions: {
-      onSuccess: async () => {
-        await queryClient.invalidateQueries("/api/sales-session");
-        setShowSuccessAlert({
-          show: true,
-          type: "updated",
-        });
-      },
-    },
-  });
-
   const {
     mutateAsync: completeCurrentSalesSession,
     isLoading: completeCurrentSalesSessionIsLoading,
@@ -134,22 +118,6 @@ export default function SalesSession() {
     },
   });
 
-  const handleOnEditCurrentSalesSessionClick = async () => {
-    await editCurrentSalesSession({
-      url: "/api/sales-session/current",
-      fetchInit: {
-        method: "PATCH",
-        headers: {
-          "Content-Type": "application/json",
-        },
-        body: JSON.stringify({
-          startDate: startDate.toISOString(),
-          sessionDurationInDays: Number(sessionDurationInDays),
-        }),
-      },
-    });
-  };
-
   const handleOnFinishCurrentSalesSessionClick = async () => {
     await completeCurrentSalesSession({
       url: "/api/sales-session/current/complete",
@@ -314,20 +282,6 @@ export default function SalesSession() {
           {createSalesSessionIsLoading ? "Loading..." : "Create Sales Session"}
         </Button>
 
-        <Button
-          variant="contained"
-          type="button"
-          onClick={handleOnEditCurrentSalesSessionClick}
-          disabled={
-            editCurrentSalesSessionIsLoading ||
-            !currentSalesSessionData?.currentSalesSession?.isActive
-          }
-        >
-          {editCurrentSalesSessionIsLoading
-            ? "Loading..."
-            : "Edit Current Sales Session"}
-        </Button>
-
         <Button
           variant="contained"
           type="button"
@@ -346,10 +300,6 @@ export default function SalesSession() {
           <Alert severity="error">{createSalesSessionError.message}</Alert>
         )}
 
-        {editCurrentSalesSessionError && (
-          <Alert severity="error">{editCurrentSalesSessionError.message}</Alert>
-        )}
-
         {completeCurrentSalesSessionError && (
           <Alert severity="error">
             {completeCurrentSalesSessionError.message}

diff --git a/web/modules/sales-session/controllers/edit-current-sales-session.js b/web/modules/sales-session/controllers/edit-current-sales-session.js
diff --git a/web/modules/sales-session/controllers/index.js b/web/modules/sales-session/controllers/index.js
@@ -2,7 +2,6 @@ import { Router } from 'express';
 
 import createSalesSession from './create-sales-session.js';
 import getCurrentSalesSession from './get-current-sales-session.js';
-import editCurrentSalesSession from './edit-current-sales-session.js';
 import deleteCurrentSalesSession from './delete-current-sales-session.js';
 import completeCurrentSalesSession from './complete-current-sales-session.js';
 
@@ -11,7 +10,6 @@ const salesSessionRouter = Router();
 salesSessionRouter.post('/', createSalesSession);
 salesSessionRouter.get('/', getCurrentSalesSession);
 salesSessionRouter.delete('/current', deleteCurrentSalesSession);
-salesSessionRouter.patch('/current', editCurrentSalesSession);
 salesSessionRouter.patch('/current/complete', completeCurrentSalesSession);
 
 export default salesSessionRouter;
diff --git a/web/modules/sales-session/use-cases/edit-current-sales-session.js b/web/modules/sales-session/use-cases/edit-current-sales-session.js
diff --git a/web/oidc-router.js b/web/oidc-router.js
@@ -18,7 +18,7 @@ oidcRouter.get('/success', async (req, res) => {
   res
     .status(200)
     .set('Content-Type', 'text/html')
-    .send(readFileSync(join(STATIC_PATH, 'success.html')))
+    .send(readFileSync(join(STATIC_PATH, 'success.html')));
 });
 
 oidcRouter.get(

diff --git a/web/utils/index.js b/web/utils/index.js
@@ -1,4 +1,3 @@
-import * as qs from 'qs';
 
 export const convertShopifyGraphQLIdToNumber = (id) => {
   if (!id) return null;
@@ -7,11 +6,7 @@ export const convertShopifyGraphQLIdToNumber = (id) => {
 };
 
 export function throwError(message, errorObj) {
-  if (errorObj) {
-    throw errorObj;
-  } else {
-    throw new Error(message);
-  }
+  throw new Error(message, errorObj ? {cause: errorObj} : null);
 }
 
 export function getTargetStringFromSemanticId(url, key) {