-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IYY-285: Site editors can add a caption to Image Banner #833
base: develop
Are you sure you want to change the base?
Conversation
Created multidev environment pr-833 for yalesites-platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and this is not part of this ticket, but I also noticed that the image banner is using the "default" view mode for images, which doesn't use a responsive image style and also doesn't work with focal point. I'll check with Duncan to see if we should add to their Jira board. |
@codechefmarc I pushed up a fix for the caption in layout-builder. It was picking up way too broadly defined I'll look into the image styes being used for the Image Banner. My Lando is refusing to run today, so it might not happen until the new year. |
I talked with David about it earlier today and they are aware of the image style for the image banner. So, no worries in looking into it, I believe they already have a ticket in place to fix eventually. |
IYY-285: Site editors can add a caption to Image Banner
Description of work
field_text
) to the image bannerFunctional testing steps: