Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IYY-285: Site editors can add a caption to Image Banner #833

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Dec 19, 2024

IYY-285: Site editors can add a caption to Image Banner

Description of work

Functional testing steps:

Copy link

Visit Site

Created multidev environment pr-833 for yalesites-platform.

@joetower joetower changed the title Iyy 285 banner captions IYY-285: Site editors can add a caption to Image Banner Dec 19, 2024
@joetower joetower marked this pull request as ready for review December 19, 2024 23:12
@joetower joetower requested a review from a team as a code owner December 19, 2024 23:12
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this looks good to me, the only thing I can see is when you are in layout builder, the caption shows up on top of the image. It looks fine once you save, so not sure if you want to make any adjustments:
Screenshot 2024-12-20 at 8 51 01 AM

@codechefmarc
Copy link
Contributor

Oh, and this is not part of this ticket, but I also noticed that the image banner is using the "default" view mode for images, which doesn't use a responsive image style and also doesn't work with focal point. I'll check with Duncan to see if we should add to their Jira board.

@joetower
Copy link
Contributor Author

@codechefmarc I pushed up a fix for the caption in layout-builder. It was picking up way too broadly defined .caption styles from Drupal.

I'll look into the image styes being used for the Image Banner. My Lando is refusing to run today, so it might not happen until the new year.

@codechefmarc
Copy link
Contributor

I talked with David about it earlier today and they are aware of the image style for the image banner. So, no worries in looking into it, I believe they already have a ticket in place to fix eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants