Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IYY:297: Create new "Coral" Theme #441

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Nov 25, 2024

IYY:297: Create new "Coral" Theme

Description of work

  • Adds new colors: deep-teal and coral
  • Adds new theme: Coral

Testing Link(s)

Functional Review Steps

Screenshot 2024-11-25 at 12-54-31 Tokens _ Colors - Global Theme Color Pairings ⋅ Storybook

Design Review

Accessibility Review

  • Verify the component meets Accessibility requirements

@joetower joetower self-assigned this Nov 25, 2024
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for dev-component-library-twig ready!

Name Link
🔨 Latest commit 911b104
🔍 Latest deploy log https://app.netlify.com/sites/dev-component-library-twig/deploys/67530d38271fa40008c69aec
😎 Deploy Preview https://deploy-preview-441--dev-component-library-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joetower joetower changed the title feat(IYY-297): update to latest tokens version to get new coral theme… IYY:297: Create new "Coral" Theme Nov 25, 2024
@joetower joetower marked this pull request as ready for review November 25, 2024 19:18
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and works over in the multidev. Approved, but my question is - where are the colors coming from? 😆 I don't see any additional colors added in CSS? Or is that from tokens/was done previously but never implemented?

@joetower
Copy link
Contributor Author

@codechefmarc I added them to the Tokens repository, merged that to cut a new release, then included the new release here 😄 .

@dblanken-yale
Copy link
Contributor

@joetower 's sneaky. 😁 Glad it's in there already!

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; was there a husky issue? Saw that bumped.

@joetower
Copy link
Contributor Author

joetower commented Dec 2, 2024

@dblanken-yale Good call on that Husky change. That was a mistake. I reverted that, but it looks like it did still update one version point when I pulled in the newest tokens release? I'm not sure it's an issue, though. What do you think? Disregard this point... I was misunderstanding the trail of changes. I think husky is now back to what it was at before.

@dblanken-yale
Copy link
Contributor

@joetower Oh it's fine; just wondered. heh Ya just keep it then. I don't mind.

@dblanken-yale
Copy link
Contributor

Doh just read with the strikeout; that's fine too heh

@miketullo95
Copy link

@joetower discussed with the university printer and Franz will let IYY know, but we are requesting to change out --global-themes-five-colors-slot-five from #163C50 -> #314253

@joetower
Copy link
Contributor Author

joetower commented Dec 6, 2024

@miketullo95 I updated the hex value for deep-teal and you should see the update here: https://deploy-preview-441--dev-component-library-twig.netlify.app/?path=/story/tokens-colors--color-global-themes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants