-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IYY:297: Create new "Coral" Theme #441
base: develop
Are you sure you want to change the base?
Conversation
…, add theme to global context
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and works over in the multidev. Approved, but my question is - where are the colors coming from? 😆 I don't see any additional colors added in CSS? Or is that from tokens/was done previously but never implemented?
@codechefmarc I added them to the Tokens repository, merged that to cut a new release, then included the new release here 😄 . |
@joetower 's sneaky. 😁 Glad it's in there already! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; was there a husky issue? Saw that bumped.
…' into IYY-297-coral-theme
@dblanken-yale Good call on that Husky change. That was a mistake. I reverted that, |
@joetower Oh it's fine; just wondered. heh Ya just keep it then. I don't mind. |
Doh just read with the strikeout; that's fine too heh |
@joetower discussed with the university printer and Franz will let IYY know, but we are requesting to change out |
@miketullo95 I updated the hex value for deep-teal and you should see the update here: https://deploy-preview-441--dev-component-library-twig.netlify.app/?path=/story/tokens-colors--color-global-themes |
IYY:297: Create new "Coral" Theme
Description of work
Testing Link(s)
Functional Review Steps
Test in the main site PR here:
Verify new "Coral" theme is present: https://deploy-preview-441--dev-component-library-twig.netlify.app/?path=/story/tokens-colors--color-global-themes
Verify you can select "Coral" from the global content bar in Storybook
Design Review
Accessibility Review