Skip to content

Commit

Permalink
Merge pull request #214 from yalesites-org/develop
Browse files Browse the repository at this point in the history
Release
  • Loading branch information
vinmassaro authored Mar 22, 2024
2 parents 5a37804 + 30f191d commit 68403d2
Show file tree
Hide file tree
Showing 9 changed files with 71 additions and 18 deletions.
1 change: 1 addition & 0 deletions atomic.info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ core_version_requirement: ^9 || ^10
libraries:
- atomic/global
- atomic/layout-builder
- atomic/fontawesome

ckeditor5-stylesheets:
- css/ckeditor5.css
Expand Down
59 changes: 53 additions & 6 deletions css/admin-theme.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

:root {
--gin-font: Mallory, sans-serif;
--gin-font-size-h1: 1.75rem;
Expand Down Expand Up @@ -73,18 +72,17 @@
}

@media only screen and (min-width: 2200px) {
.yds-two-column .layout-builder-block.contextual-region .contextual {
.yds-two-column .layout-builder-block.contextual-region .contextual {
left: -1vw;
}
}

@media only screen and (min-width: 2500px) {
.yds-two-column .layout-builder-block.contextual-region .contextual {
.yds-two-column .layout-builder-block.contextual-region .contextual {
left: -1vw;
}
}


/* add min-height so that smaller (in height) components are more easily
// able to be interacted with - e.g. `divider`
*/
Expand Down Expand Up @@ -117,7 +115,7 @@
/*
// Autocomplete styles (linkit)
*/
.ui-autocomplete .ui-menu-item-wrapper:focus,
.ui-autocomplete .ui-menu-item-wrapper:focus,
.ui-autocomplete .ui-menu-item-wrapper:hover {
background-color: var(--gin-color-primary);
color: var(--gin-bg-layer3);
Expand Down Expand Up @@ -165,6 +163,55 @@

/* In light mode, gin is displaying a mustard background with a black
foreground. This causes contrast issues. */
html:not(.gin--dark-mode) #drupal-off-canvas:not(.drupal-off-canvas-reset).ui-dialog-content div:not([data-drupal-ck-style-fence] *), #drupal-off-canvas-wrapper .ui-dialog-content div:not([data-drupal-ck-style-fence] *) {
html:not(.gin--dark-mode)
#drupal-off-canvas:not(.drupal-off-canvas-reset).ui-dialog-content
div:not([data-drupal-ck-style-fence] *),
#drupal-off-canvas-wrapper
.ui-dialog-content
div:not([data-drupal-ck-style-fence] *) {
color: var(--color-basic-white);
}

/*
* GinLB has a spinning text that we do not want in our system, so we disabled
* the animation of the throbber wrapper.
*
* By attempting to hide this, the delete and edit links were appearing above
* the message being displayed to the user. This ensures that the z-index is
* respected such that the message will show and the buttons will not be shown
* during the throbber.
*
* We then do the same for the ui-dialog version since it also was clipping the
* text with link icons.
*/
.ui-dialog .ajax-progress,
.ui-dialog .ajax-progress-throbber {
background-color: var(--gin-bg-layer) !important;

/* For some reason the throbber container had a border-radius? */
border-radius: unset !important;
display: block;

/*
* Setting a height of 100 in this case will cover the image. So we set a
* lower height that will still cover the links
*/
height: var(--spacing-component-gutter);
z-index: 10;
}

#drupal-off-canvas-wrapper .ajax-progress,
#drupal-off-canvas-wrapper .ajax-progress-throbber {
animation: none;
background-color: var(--gin-bg-layer) !important;

/* For some reason the throbber container had a border-radius? */
border-radius: unset;
display: block;
height: 100%;
z-index: 10;
}

.ajax-progress-throbber::before {
right: 0;
}
1 change: 1 addition & 0 deletions css/layout-builder.css
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,4 @@ div[data-drupal-selector="edit-block-form"] {
#block-yalesitesfooterblock {
margin-top: auto;
}

12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@

{% block content %}

{{ attach_library('atomic/fontawesome') }}

{% embed "@molecules/banner/grand-hero/yds-grand-hero.twig" with {
grand_hero__heading: content.field_heading,
grand_hero__heading__level: content.field_heading_level.0['#markup'],
grand_hero__snippet: content.field_text,
grand_hero__snippet: content.field_text.0,
grand_hero__link__content: content.field_link.0['#title'],
grand_hero__link__url: content.field_link.0['#url_title'],
grand_hero__content__background: content.field_style_color.0['#markup'],
Expand Down
3 changes: 3 additions & 0 deletions templates/field/field--block-content--text.html.twig
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{% for item in items %}
{{ item.content }}
{% endfor %}
1 change: 0 additions & 1 deletion templates/navigation/menu--extras--main.html.twig
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{# Note: After enabling menu_item_extras module, this file was renamed from menu--main.html.twig #}
{{ attach_library('atomic/primary-nav') }}
{{ attach_library('atomic/fontawesome')}}

{% include "@organisms/menu/primary-nav/yds-primary-nav.twig" with {
menu__variation: getHeaderSetting('header_variation'),
Expand Down
2 changes: 1 addition & 1 deletion templates/node/node--event--card.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
} %}
{% endset %}

{% if content.field_event_type %}
{% if content.field_event_type.0 %}
{% set reference_card__overline -%}
{% include "@molecules/cards/reference-card/event/_yds-event-format.twig" with {
format: content.field_event_type,
Expand Down
6 changes: 5 additions & 1 deletion templates/paragraphs/_gallery-item.twig
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
media_grid__variation: 'interactive',
} %}
{% block media_grid_item__media %}
{{ drupal_entity('media', item.entity.field_media.0.entity.mid.value, 'card_secondary_3_2') }}
{% if (item.entity.field_media.0.entity.mid != NULL) %}
{{ drupal_entity('media', item.entity.field_media.0.entity.mid.value, 'card_secondary_3_2') }}
{% else %}
{% include "@atoms/images/image/_image.twig" %}
{% endif %}
{% endblock %}
{% endembed %}
{% endfor %}
Expand Down

0 comments on commit 68403d2

Please sign in to comment.