ServerSerial types and usage #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the pull request |
yaacov
reviewed
Apr 4, 2024
| @@ -253,7 +253,7 @@ class ServerSerial extends EventEmitter { | |||
| // remember open sockets | |||
| modbus.socks = new Map(); | |||
|
|
|||
| modbus._server.on("open", function() { | |||
There was a problem hiding this comment.
Hi, can you give some description what this do, and why this change is needed ?
There was a problem hiding this comment.
The open event never gets emitted.
I think it may be because of how ServerSerialPipeHandler works?
But the open event from SerialPort isn't piped and so you never receive an initialized event either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking on how to use the ServerSerial in my TypeScript project, but had to look in the code to figure it out.
This is quickly patched to be able to work with TypeScript, but I'm starting the conversation to make it to the codebase.
Open to comment, feedback and reviews.
Related to #503