Remove experimental flag for webcomponents (SAP#2622)

y-kkamil · Mar 24, 2022 · 319a7c1 · 319a7c1
1 parent d6dc8f0
commit 319a7c1
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 22 deletions.
diff --git a/core/src/services/routing.js b/core/src/services/routing.js
@@ -351,13 +351,13 @@ class RoutingClass {
         }
       }
 
-      if (nodeObject.compound && GenericHelpers.requestExperimentalFeature('webcomponents', true)) {
+      if (nodeObject.compound) {
         if (iContainer) {
           iContainer.classList.add('lui-webComponent');
         }
         Iframe.switchActiveIframe(iframeElement, undefined, false);
         this.navigateWebComponentCompound(component, nodeObject);
-      } else if (nodeObject.webcomponent && GenericHelpers.requestExperimentalFeature('webcomponents', true)) {
+      } else if (nodeObject.webcomponent) {
         if (iContainer) {
           iContainer.classList.add('lui-webComponent');
         }

diff --git a/docs/web-component.md b/docs/web-component.md
@@ -51,15 +51,11 @@ Luigi.setConfig({
 		...
 		]
 	}
-    settings: {
-   ...
-        experimental: {
-        webcomponents:true
-        }
-	.......
 })
 ```
 
+> **NOTE:** With Luigi version NEXTRELEASE we removed the experimental flag for webcomponents. 
+
 ### Write a Web Component
 
 There are a couple of differences between Luigi Web Components and standard ones:

diff --git a/test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js b/test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js
@@ -632,11 +632,6 @@ describe('Luigi client linkManager', () => {
   describe('Webcomponent visibleForFeatureToggles test', () => {
     beforeEach(() => {
       cy.visitLoggedIn('/projects/pr1/wc_grid');
-      cy.window().then(win => {
-        const config = win.Luigi.getConfig();
-        config.settings.experimental = { webcomponents: true };
-        win.Luigi.configChanged();
-      });
     });
 
     it('open webcomponent with visibleForFeatureToggles', () => {
@@ -654,11 +649,6 @@ describe('Luigi client linkManager', () => {
   describe('Webcomponent compound view test', () => {
     beforeEach(() => {
       cy.visitLoggedIn('/projects/pr1/wc_grid_compound');
-      cy.window().then(win => {
-        const config = win.Luigi.getConfig();
-        config.settings.experimental = { webcomponents: true };
-        win.Luigi.configChanged();
-      });
     });
 
     it('open webcomponent btn', () => {

diff --git a/test/e2e-test-application/src/luigi-config/extended/settings.js b/test/e2e-test-application/src/luigi-config/extended/settings.js
@@ -65,7 +65,6 @@ class Settings {
   // experimental = {
   //   profileMenuFiori3: true,
   //   globalNav: true,
-  //   webcomponents: true
   // };
   // globalSideNavigation = true;
 }

diff --git a/website/fiddle/src/defaultConfig.js b/website/fiddle/src/defaultConfig.js
@@ -188,9 +188,6 @@ Luigi.setConfig({
                 logo: 'img/luigi.png', 
                 title: 'Luigi Fiddle'
             },
-            experimental: {
-              webcomponents:true
-            },
             burgerTooltip: {
                 navExpanded: 'Collapse navigation',
                 navCollapsed: 'Expand navigation'