Function addNodeParams does not delete properties with value undefined (

SAP#2472)
y-kkamil · Jan 14, 2022 · 1522522 · 1522522
1 parent c17606a
commit 1522522
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/core/src/core-api/routing.js b/core/src/core-api/routing.js
@@ -73,7 +73,7 @@ class LuigiRouting {
 
       searchParams.set(paramKey, value);
       if (value === undefined) {
-        searchParams.delete(key);
+        searchParams.delete(paramKey);
       }
     }
   }

diff --git a/core/test/core-api/routing.spec.js b/core/test/core-api/routing.spec.js
@@ -59,12 +59,18 @@ describe('Luigi routing', function() {
       LuigiRouting.addSearchParams('bar', true);
       sinon.assert.calledWith(console.log, 'Params argument must be an object');
     });
-    it('delete search params from url', () => {
+    it('delete search params from url with keepBrowserHistory is true', () => {
       window.state = {};
       global.location = 'http://some.url.de?luigi=rocks&mario=red';
       LuigiRouting.addSearchParams({ mario: undefined }, true);
       sinon.assert.calledWithExactly(window.history.pushState, window.state, '', 'http://some.url.de/?luigi=rocks');
     });
+    it('delete search params from url with keepBrowserHistory is false', () => {
+      window.state = {};
+      global.location = 'http://some.url.de?luigi=rocks&mario=red';
+      LuigiRouting.addSearchParams({ mario: undefined }, false);
+      sinon.assert.calledWithExactly(window.history.replaceState, window.state, '', 'http://some.url.de/?luigi=rocks');
+    });
   });
   describe('SearchParams hash routing', () => {
     beforeEach(() => {
@@ -182,5 +188,15 @@ describe('Luigi routing', function() {
       LuigiRouting.addNodeParams('bar', true);
       sinon.assert.calledWith(console.log, 'Params argument must be an object');
     });
+    it('remove node param if value of params object is undefined', ()=>{
+      window.state = {};
+      global.location = 'http://some.url.de';
+      LuigiRouting.addNodeParams({ test: undefined }, false);
+      sinon.assert.calledWithExactly(window.history.replaceState, window.state, '', 'http://some.url.de/');
+      LuigiRouting.addNodeParams({ foo: 'bar' }, false);
+      sinon.assert.calledWithExactly(window.history.replaceState, window.state, '', 'http://some.url.de/?%7Efoo=bar');
+      LuigiRouting.addNodeParams({ foo: undefined }, false);
+      sinon.assert.calledWithExactly(window.history.replaceState, window.state, '', 'http://some.url.de/');
+    });
   });
 });