Skip to content

Commit

Permalink
Minor improvements to setup.py
Browse files Browse the repository at this point in the history
* Re-use `read` to read `README.rst`
* Do `install_requires` in one go, merge it with its key
* Classifiers
  * Add:
    * `Environment :: Console`
    * `Programming Language :: Python :: 3 :: Only`
    * `Topic :: Utilities`
  * Re-order them lexicographically

Signed-off-by: Stavros Ntentos <[email protected]>
  • Loading branch information
stdedos authored and xyb committed Jun 30, 2020
1 parent c572be0 commit 0c87800
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,11 @@
from setuptools import setup

ROOT = os.path.abspath(os.path.dirname(__file__))
README = open(os.path.join(ROOT, 'README.rst')).read()

install_requires = ['prompt-toolkit < 3'] # 3.0 is not compatible with py3.5
install_requires.append('robotframework >= 3.0')


def read(*names, **kwargs):
with io.open(
os.path.join(os.path.dirname(__file__), *names),
os.path.join(ROOT, *names),
encoding=kwargs.get("encoding", "utf8")
) as fp:
return fp.read()
Expand All @@ -34,7 +30,7 @@ def find_version(*file_paths):
name='robotframework-debuglibrary',
version=find_version('DebugLibrary/version.py'),
description='RobotFramework debug library and an interactive shell',
long_description=README,
long_description=read('README.rst'),
author='Xie Yanbo',
author_email='[email protected]',
license='New BSD',
Expand All @@ -48,19 +44,25 @@ def find_version(*file_paths):
zip_safe=False,
url='https://github.com/xyb/robotframework-debuglibrary/',
keywords='robotframework,debug,shell,repl',
install_requires=install_requires,
install_requires=[
'prompt-toolkit < 3', # 3.0 is not compatible with py3.5
'robotframework >= 3.0',
],
tests_require=['pexpect', 'coverage'],
test_suite='tests.test_debuglibrary.suite',
platforms=['Linux', 'Unix', 'Windows', 'MacOS X'],
classifiers=[
'Environment :: Console',
'Development Status :: 5 - Production/Stable',
'License :: OSI Approved :: BSD License',
'Natural Language :: English',
'Operating System :: OS Independent',
'Programming Language :: Python',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Operating System :: OS Independent',
'License :: OSI Approved :: BSD License',
'Natural Language :: English',
'Topic :: Utilities',
],
)

0 comments on commit 0c87800

Please sign in to comment.