XWIKI-17664: When adding an annotation the focus should be inside WYSIWYG by default #3694
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IWYG by default * Added a comment to explain a line of code that doesn't work with CKEditor anymore * Added a CKE config change so that it gets focus when loaded.
|
Assigning surli to this ticket since he reviewed and merged #3239 which was a very similar solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-17664
Changes
Description
Clarifications
Screenshots & Video
On the video below, we can see a basic use case and experimentation with adjacent UIs (namely inline editing and comment edition).
2024-11-26.14-56-41.mp4
Executed Tests
Manual tests, see above.
I doubt the changes would change anything to tests since it's only a minor CKEditor config update (and the docker tests pretty much don't care about the focus state).
Built changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-uiand then successfully passed the docker test suite:mvn clean install -f xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-test/xwiki-platform-annotation-test-docker.Expected merging strategy