[Misc] Improve consistency of global LESS variable declaration in Flamingo

[Sereza7]

Jira URL

None, quality change only.

Changes

Description

• Moved the global LESS variables declarations to variables.less.
• Renamed @loginFormMaxWidth to @login-form-max-width
• Moved @border-width from the override section to the XWiki specific section (it was incorrectly set here...)
• Fixed a couple typos, the past participle of to override is overridden :)

Clarifications

• All of the "removed" code was put back in another less file, which is loaded in the same context. See

  xwiki-platform/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/style.less.vm

  Line 27 in 7683202

  @import "variables"; // Bootstrap variables overridden by flamingo and XWiki specific LESS variables.

  . This is just a reorganization to make it easier/cleaner to solve XWIKI-22667 down the line.
• The variable @loginFormMaxWidth was renamed because it did not respect our naming convention (strictly speaking we don't have one for naming LESS variables, but we have one for HTML/CSS classes and bootstrap had one that we followed for pretty much all other variables). This is technically a backward compatibility break, but the name and use of this variable is so niche that I doubt anyone used it in a customization...

Screenshots & Video

None, code quality changes only.

Executed Tests

Passed mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin -Pquality,docker without an issue.
I conducted a quick manual test by moving the changes related to font size on my local instance. After a reset of the instance and its LESS cache, the titles still had the right font size 👍 .

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • 16.10.X