add config safety check #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fsdp tp > 1 bug fix Signed-off-by: dimapihtar <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix fsdp for fp16 precision Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Use fp16 in unet if cfg.precision is 16bit Signed-off-by: Alexandros Koumparoulis <[email protected]> * remove temp fix Signed-off-by: Alexandros Koumparoulis <[email protected]> * guard unet_precision value setting Signed-off-by: Alexandros Koumparoulis <[email protected]> * formatting Signed-off-by: Alexandros Koumparoulis <[email protected]> * throw a warning if unet_config.unet_precision is not set but trainer.precision is set Signed-off-by: Alexandros Koumparoulis <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use model.optim.name=megatron_fused_adam in sd_train Signed-off-by: Alexandros Koumparoulis <[email protected]> * use bf16 in sd_train Signed-off-by: Alexandros Koumparoulis <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: eharper <[email protected]>
* Detect 'arcname' prefix in utils when handling .nemo tarball Signed-off-by: Jan Lasek <[email protected]> * Address megatron_amp_O2 = True case in quantization Signed-off-by: Jan Lasek <[email protected]> * Add Megatron-LM to PYTHONPATH correctly in Jenkinsfile Signed-off-by: Jan Lasek <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
* PR NVIDIA#8803: Update embedding init prototype to match mc Signed-off-by: Jaemin Choi <[email protected]> * PR NVIDIA#8810: Fix import of get_gpt_layer_ammo_spec Signed-off-by: Jaemin Choi <[email protected]> * PR NVIDIA#8853: Fix memory leak at loss func Signed-off-by: Jaemin Choi <[email protected]> --------- Signed-off-by: Jaemin Choi <[email protected]> Signed-off-by: Shriya Palsamudram <[email protected]> Co-authored-by: Jaemin Choi <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: Shriya Palsamudram <[email protected]> Co-authored-by: Pablo Garay <[email protected]>
* initial commit Signed-off-by: Chen Cui <[email protected]> * enable pp support for merge script and fix output precision Signed-off-by: Chen Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove incomplete script for next release Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: Chen Cui <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Adi Renduchintala <[email protected]> Co-authored-by: Eric Harper <[email protected]>
* Move cached embedding devices and dtype for onnx export consistency Signed-off-by: Mingyuan Ma <[email protected]> * Add old trt export/inference script, currently not working in latest container. Signed-off-by: Mingyuan Ma <[email protected]> * Add NeMo TRT inference pipeline and quatization workflow Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add guards to avoid undefined variables Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * minor fix Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add conversion script from hf sdxl to nemo sdxl Signed-off-by: Mingyuan Ma <[email protected]> * Update quantize pipeline to adapt to variable image dimension Signed-off-by: Mingyuan Ma <[email protected]> * update sdxl pipeline to be aware of additional emb channels Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add guards for potential local var Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * copyright header Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update calib prompt file path Signed-off-by: Mingyuan Ma <[email protected]> * Update file paths Signed-off-by: Mingyuan Ma <[email protected]> * minor update Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update default quantization config Signed-off-by: Mingyuan Ma <[email protected]> * remove unused imports/vars Signed-off-by: Mingyuan Ma <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports Signed-off-by: Mingyuan Ma <[email protected]> --------- Signed-off-by: Mingyuan Ma <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…8866) * Replaced unpacking of nemo checkpoints on export with a VFS-like TarPath object. Signed-off-by: Alexey Panteleev <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed the signature of ZarrPathStore.__delitem__ Signed-off-by: Alexey Panteleev <[email protected]> --------- Signed-off-by: Alexey Panteleev <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Onur Yilmaz <[email protected]>
Signed-off-by: eharper <[email protected]>
…A#8965) Signed-off-by: HuiyingLi <[email protected]> Co-authored-by: Adi Renduchintala <[email protected]>
* Update Latest News Adds links to articles on * NeMo framework on GKE * Responsible Gen AI using NeMo and Picasso * NeMo powering Amazon Titan foundation models Signed-off-by: Shashank Verma <[email protected]> * Minor updates to latest news in README * Remove bullets * Editing text for clarity Signed-off-by: Shashank Verma <[email protected]> * Format latest news as a dropdown list * Uses embedded html to format news to dropdown, hiding lengthy details * Fixes formatting of the title Signed-off-by: Shashank Verma <[email protected]> * Add break to improve readability of latest news image Signed-off-by: Shashank Verma <[email protected]> * Add LLM and MM section in latest news Signed-off-by: Shashank Verma <[email protected]> * Add margin in latest news expandable lists Signed-off-by: Shashank Verma <[email protected]> * Remove styling of expandable list * Github appears to not render styled elements when embedded as raw html in rst Signed-off-by: Shashank Verma <[email protected]> * Fold the first news item by default Signed-off-by: Shashank Verma <[email protected]> --------- Signed-off-by: Shashank Verma <[email protected]> Signed-off-by: Shashank Verma <[email protected]>
Signed-off-by: Shashank Verma <[email protected]>
Signed-off-by: HuiyingLi <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| continue | ||
| if isinstance(module, (torch.nn.Linear, LinearWrapper)): | ||
| if ( | ||
| (quant_level >= 2 and "ff.net" in name) |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
| module.weight_quantizer.enable() | ||
| elif isinstance(module, (torch.nn.Linear, LinearWrapper)): | ||
| if ( | ||
| (quant_level >= 2 and "ff.net" in name) |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
|
|
||
| def __repr__(self): | ||
| s = "PercentileCalibrator(" | ||
| s += super(MaxCalibrator, self).__repr__() |
Check failure
Code scanning / CodeQL
First argument to super() is not enclosing class Error
| # limitations under the License. | ||
|
|
||
| import math | ||
| import time |
Check notice
Code scanning / CodeQL
Unused import Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information