Fix issue #4 #5
Open
Fix issue #4 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haakym I merged I have only one question: on Windows the Ghostscript come with system or need to be installed? Could be usefull to add install instructions on README.md. @edegaudenzi Do you have suggestions to also support macOS here? |
|
-MacOS
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issues #3 and #4
Would appreciate feedback for
src/Converter/GhostscriptConverterCommand.php, not an ideal solution and more of a proof of concept. Perhaps the whole guess the GhostScript command by OS should be extracted to an external class? Scratching my head on how to write tests for this also!