Fixes #44 calculation with complex when Im is negative

xoofx · Mar 25, 2024 · b38a84e · b38a84e
1 parent 724fdc0
commit b38a84e
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/site/doc/api/math.generated.md b/site/doc/api/math.generated.md
@@ -624,6 +624,9 @@ A complex number.
 >>> 1 + 2i
 # 1 + 2 * i
 out = 1 + 2i
+>>> i ^ 3
+# i ^ 3
+out = i
 ```
 
 ## imag

diff --git a/src/Kalk.Core/KalkEngine.generated.cs b/src/Kalk.Core/KalkEngine.generated.cs
@@ -1,7 +1,7 @@
 //------------------------------------------------------------------------------
 // <auto-generated>
 //     This code was generated by a tool.
-//     Date: 16 Sep 2023
+//     Date: 25 Mar 2024
 //
 //     Changes to this file may cause incorrect behavior and will be lost if
 //     the code is regenerated.
@@ -26953,6 +26953,9 @@ private void RegisterDocumentationAuto()
                 descriptor.Example = @"    >>> 1 + 2i
     # 1 + 2 * i
     out = 1 + 2i
+    >>> i ^ 3
+    # i ^ 3
+    out = i
 ";
             }
             {

diff --git a/src/Kalk.Core/Model/KalkComplex.cs b/src/Kalk.Core/Model/KalkComplex.cs
@@ -35,7 +35,7 @@ public KalkComplex(Complex value)
 
         public double Magnitude => _value.Magnitude;
 
-        public bool HasIm => _value.Imaginary > MaxRoundToZero;
+        public bool HasIm => Math.Abs(_value.Imaginary) > MaxRoundToZero;
 
         internal Complex Value => _value;
 

diff --git a/src/Kalk.Core/Modules/MathModule.cs b/src/Kalk.Core/Modules/MathModule.cs
@@ -145,6 +145,9 @@ public MathModule()
         /// >>> 1 + 2i
         /// # 1 + 2 * i
         /// out = 1 + 2i
+        /// >>> i ^ 3
+        /// # i ^ 3
+        /// out = i
         /// ```
         /// </example>
         [KalkExport("i", CategoryMathFunctions)]

diff --git a/src/Kalk.Tests/KalkTests.generated.cs b/src/Kalk.Tests/KalkTests.generated.cs
@@ -1,7 +1,7 @@
 //------------------------------------------------------------------------------
 // <auto-generated>
 //     This code was generated by a tool.
-//     Date: 16 Sep 2023
+//     Date: 25 Mar 2024
 //
 //     Changes to this file may cause incorrect behavior and will be lost if
 //     the code is regenerated.
@@ -904,8 +904,11 @@ public partial class MathModuleTests : KalkTestBase
         /// <summary>
         /// Test for <see cref="M:Kalk.Core.MathModule.ComplexNumber"/> or `i`.
         /// </summary>
-        [TestCase(@"1 + 2i", @"# 1 + 2 * i
-out = 1 + 2i", Category = "Math Functions")]
+        [TestCase(@"1 + 2i
+i ^ 3", @"# 1 + 2 * i
+out = 1 + 2i
+# i ^ 3
+out = i", Category = "Math Functions")]
         public static void Test_i(string input, string output) => AssertScript(input, output);
 
         /// <summary>