Do not clobber v:this_session during session save #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving a session, the plugin uses :mksession with a temp file, whose name is generated via tempname(). If no session so far existed, Vim will derive a session name (and put this into v:this_session) from that temp file name, e.g. /tmp/v3CCl7f/20 will turn into v:this_session = "20". Now, when another (unnamed) session is saved, the plugin will pick up v:this_session and use "20" instead of "default", which is irritating and unexpected. Easy fix: Save and restore the value of v:this_session.
|
Hey, I'm trying to create a community maintained version of this plugin due to the disparition of the maintainer, if you're interested you can open this PR at https://github.com/romgrk/vim-session. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Peter, haven't heard from each other in quite a while. I've been using your plugin(s) happily :-) I hope you're well and you still maintain your plugins, because here's a tiny fix:
When saving a session, the plugin uses
:mksessionwith a temp file, whose name is generated viatempname(). If no session so far existed, Vim will derive a session name (and put this intov:this_session) from that temp file name, e.g./tmp/v3CCl7f/20will turn intov:this_session = "20". Now, when another (unnamed) session is saved, the plugin will pick upv:this_sessionand use"20"instead of"default", which is irritating and unexpected.Easy fix: Save and restore the value of
v:this_session.