XS-414 weekdays bug fix and removed unnecessary console log #348
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojx031
commented
Sep 17, 2024
|
|
||
| /** We don't want any localization-related props for "English" */ | ||
| if (!locale || locale === "en" || locale === "en_US") return; | ||
| if (!localeCode || localeCode === "en" || localeCode === "en-us") return; |
There was a problem hiding this comment.
we are getting the locale in en-US format, not in en_US format. and english locale object won't have weekdays key in the locale obj, so getting the issue .weekdays doesn't exist.
rushi
approved these changes
Sep 17, 2024
rushi
added a commit
to rushi/ui-kit
that referenced
this pull request
Sep 20, 2024
# By Manoj Vaibhav (18) and others # Via GitHub (10) and others * 'master' of github.com:xola/ui-kit: (98 commits) XS-414 weekdays bug fix and removed unnecessary console log (xola#348) XS-30 | Multi language support - Xola app content (xola#334) Do not checkout & run workflow if user is not in Xola (xola#347) Explicitly specify GITHUB_TOKEN Set `permissions` on eslint.yml workflow Use default token Update token for eslint annotate 2.3.12 Update eslint.yml X2-10410 Dashboard search overlap issue fix (xola#342) 2.3.11 X2-10394 Cannot filter by date range in Purchases tab for seller (xola#341) 2.3.10 Update to use event X2-10221 | fixed datepicker for specific case (xola#336) X2-9433 Breakdown Item line fix (xola#337) 2.3.8 X2-10131 Mobile browser: The page refreshes when you try to select a message template in the Send a Message pop-up if zoomed in (xola#333) 2.3.7 X2-9962 Lazy mounting for popovers for performance (xola#330) ... # Conflicts: # .github/workflows/deploy.yml # .xo-config.json # package-lock.json # package.json # src/components/Forms/BaseInput.jsx # src/helpers/browser.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.