X2-9506 added future date range for relative date range picker #340
Conversation
| @@ -128,6 +101,14 @@ const handlers = { | |||
| }; | |||
| }, | |||
|
|
|||
| [options.NEXT_DAY]: (timezone) => { | |||
| const nextDay = now(null, timezone).add(1, "day"); // Added | |||
There was a problem hiding this comment.
| const nextDay = now(null, timezone).add(1, "day"); // Added | |
| const nextDay = now(null, timezone).add(1, "day"); |
| @@ -150,6 +131,14 @@ const handlers = { | |||
| }; | |||
| }, | |||
|
|
|||
| [options.NEXT_WEEK]: (timezone) => { | |||
| const nextWeek = now(null, timezone).add(7, "day"); | |||
There was a problem hiding this comment.
This maybe better for readability and consistency since you're using 'week' below.
| const nextWeek = now(null, timezone).add(7, "day"); | |
| const nextWeek = now(null, timezone).add(1, "week"); |
Check if this is different from (7, "days")
| @@ -191,6 +188,14 @@ const handlers = { | |||
| }; | |||
| }, | |||
|
|
|||
| [options.NEXT_QUARTER]: (timezone) => { | |||
| const nextQuarter = now(null, timezone).add(3, "month"); | |||
There was a problem hiding this comment.
Can you do .add(1, "quarter") here?
| @@ -220,13 +233,22 @@ export const RelativeDateRange = ({ | |||
| onChange, | |||
| onSubmit, | |||
| timezoneName, | |||
| isFutureDatesAllowed = false, // New prop | |||
There was a problem hiding this comment.
// New prpo => maynot needed.
you can add comment of what it does, or add in Ui lit story board https://ui.xola.io/?path=/docs/data-display-date-time-date-range-picker--relative-date-ranges
| const filterFutureDates = (options) => { | ||
| if (!isFutureDatesAllowed) { | ||
| // Filter out future date options | ||
| return options.filter((option) => !option.value.includes("next")); |
There was a problem hiding this comment.
can you check with Future date instead of checking just "next" text
const futureDates = [options.NEXT_QUARTER, ....] and check if not exist here
| @@ -258,4 +284,5 @@ RelativeDateRange.propTypes = { | |||
| showApply: PropTypes.bool, | |||
| value: PropTypes.string, | |||
| timezoneName: PropTypes.string, | |||
| isFutureDatesAllowed: PropTypes.bool, // New prop type | |||
There was a problem hiding this comment.
same // New prpo => maynot needed.
you can add comment of what it does, or add in Ui lit story board https://ui.xola.io/?path=/docs/data-display-date-time-date-range-picker--relative-date-ranges
| }) => { | ||
| const handleChange = (e) => { | ||
| const rangeName = e.target.value; | ||
| const range = handlers[rangeName](timezoneName); | ||
| onChange(rangeName, range); | ||
| }; | ||
|
|
||
| const filterFutureDates = (options) => { |
There was a problem hiding this comment.
this func. we are try moving out from component
There was a problem hiding this comment.
yes please. move it out of the component.
No description provided.