Fix substitution of quoted variables #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murfffi
force-pushed
the
fix/testcli-postgres
branch
3 times, most recently
from
d25078b to
8c5c3b8
Compare
murfffi
force-pushed
the
fix/testcli-postgres
branch
from
8c5c3b8 to
066926f
Compare
murfffi
changed the title
murfffi
force-pushed
the
fix/testcli-postgres
branch
from
066926f to
779bef2
Compare
|
Please advise if a new unit test is needed here. stmt_test.go contains tests for statement parsing (TestNextResetState) and substitution (TestVarSubstitute) but I didn't see a test for both at the same time. (I might have missed it - there is a lot of tests.) Maybe this is where testcli.go comes in though it took me some time to get from the testcli.go failure to the root cause. |
ccoVeille
reviewed
Dec 17, 2024
testcli.go failed before the fix and passes after it. Also includes a fix to testcli.go itself.
murfffi
force-pushed
the
fix/testcli-postgres
branch
from
779bef2 to
b37c28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testcli.go failed before the fix and passes after it.
Also includes a fix to testcli.go itself.
Closes #505 .