Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename fetch_key_packages to get_identity_updates #75

Closed
wants to merge 4 commits into from

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 22, 2024

Closes #62

closes #61

Sorry for combining, I thought they were similar enough and forgot 62 was an issue. 61 would have been quite small -- I can split up to make the PRs even smaller if requested

  • rename fetch_key_packages & related structs to get_identity_updates.
  • add timestamp to return of get_identity_updates
  • add regex in integration tests for checking did_urls with timestamp
  • generally integration tests need to use Bytes::from_hex

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (2f93b91) to head (54a68d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   78.75%   79.36%   +0.60%     
==========================================
  Files          14       14              
  Lines         579      596      +17     
==========================================
+ Hits          456      473      +17     
  Misses        123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insipx insipx marked this pull request as ready for review February 22, 2024 21:52
@insipx insipx closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant