-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some bugs during demo development #66
Conversation
- fix bug where we generated two wallets in methods & gateway context leading to insufficient funds error - add a `registry-localnet` binary that launches an anvil instance with the registry already deployed - generally add some more logging
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 91.16% 89.86% -1.31%
==========================================
Files 12 12
Lines 419 444 +25
==========================================
+ Hits 382 399 +17
- Misses 37 45 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already merged but would like to point out that registry-localnet
could be renamed to localnet
because we might add more deployed smart contracts there. otherwise lgtm
I actually gotta do a follow up anyway because i screwed up the DID_REGISTRY address, good callout! |
wallet_address
andbalance
registry-localnet
binary that launches an anvil instance with the registry already deployed. Useful for local testing E2E with libxmtp, without touching Sepolia