Refactor and simplify color handling #257
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and simplify color handling
...instead of...
isColor ? X : Y
nearly everywhere, andX
andY
are basically the identical stringit doesn't matter if there are some apostrophes around the colored action letter for example,
plus then the content is identical aside from the color which just makes sense
Also refactored all the color defines, both so they stack and build from single definitions, and all primitives of ANSI attribute control used elsewhere in code are now there (
\x1B[
everywhere was UUUUUUgly)MUCH easier to change/add/check things, also can generate color even over in other sections (RED_BOLD on the self-test fail for example - it will get stripped if noncolor output destination, yay!)