Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid concurrency issue when multiple requests are made with the same key #46

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

mirland
Copy link
Collaborator

@mirland mirland commented Oct 31, 2024

This pr adds a session id to track the different sessions, this is used to track the different notifications that are pending

@mirland mirland requested a review from a team as a code owner October 31, 2024 01:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (c997515) to head (a95781d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          14       14           
  Lines         234      234           
=======================================
  Hits          230      230           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirland mirland merged commit a23dd83 into main Oct 31, 2024
3 checks passed
@mirland mirland deleted the fix/concurrency-issue branch October 31, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants