Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart 3 upgrade #38

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Dart 3 upgrade #38

merged 4 commits into from
Oct 5, 2023

Conversation

mirland
Copy link
Collaborator

@mirland mirland commented Oct 5, 2023

Note

  • DCM was removed because it has not a free plan

@mirland mirland requested a review from a team as a code owner October 5, 2023 10:30
@mirland mirland force-pushed the feature/upgrade-to-dart-3 branch 3 times, most recently from 6e18636 to 8addc0b Compare October 5, 2023 11:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6a2f54f) 98.33% compared to head (b009ff9) 98.32%.

❗ Current head b009ff9 differs from pull request most recent head 9ca8e71. Consider uploading reports for the commit 9ca8e71 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   98.33%   98.32%   -0.01%     
==========================================
  Files          14       14              
  Lines         240      239       -1     
==========================================
- Hits          236      235       -1     
  Misses          4        4              
Files Coverage Δ
...extensions/stock_response_internal_extensions.dart 100.00% <ø> (ø)
lib/src/implementations/factory_fetcher.dart 100.00% <100.00%> (ø)
lib/src/stock_response.dart 100.00% <100.00%> (ø)
lib/src/stock_response_extensions.dart 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -4,18 +4,13 @@ on: [pull_request]

jobs:
check:
name: dart-code-metrics-action
runs-on: ubuntu-latest
name: code-metrics-action
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe different name?, since it will no longer run code metrics

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mirland mirland merged commit c30a12c into main Oct 5, 2023
1 of 2 checks passed
@mirland mirland deleted the feature/upgrade-to-dart-3 branch October 5, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants