Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] chore: Make zod work with prisma #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] chore: Make zod work with prisma #52

wants to merge 1 commit into from

Conversation

gabrielmachin
Copy link
Collaborator

JIRA Ticket

Type of change

  • Fix
  • Story
  • Chore

Description of the change

Didn't found a way to avoid creating the files under the inputTypeSchemas folder.

mlvieras
mlvieras reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@mlvieras mlvieras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not using the types anywhere? Shouldn't we be importing them and forcing them on methods and endpoints?

@gabrielmachin
Copy link
Collaborator Author

gabrielmachin commented Jan 22, 2024 •
edited
Loading

Why are we not using the types anywhere? Shouldn't we be importing them and forcing them on methods and endpoints?

Yep, forgot the wip label, my bad.

@gabrielmachin gabrielmachin changed the title chore: Make zod work with prisma [WIP] chore: Make zod work with prisma Jan 22, 2024
@chaba11 chaba11 requested review from Copilot and removed request for MBerguer November 18, 2024 18:59
Copilot
Copilot AI reviewed Nov 18, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 18 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • package.json: Language not supported
  • prisma/schema.prisma: Language not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@mlvieras mlvieras mlvieras left review comments

@lauta2912 lauta2912 Awaiting requested review from lauta2912 lauta2912 is a code owner

@chaba11 chaba11 Awaiting requested review from chaba11 chaba11 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielmachin @mlvieras